Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MMI] adds Snaps support to MMI build #20970

Merged
merged 4 commits into from
Sep 24, 2023
Merged

[MMI] adds Snaps support to MMI build #20970

merged 4 commits into from
Sep 24, 2023

Conversation

zone-live
Copy link
Contributor

Description

We are enabling Snaps for MMI, by adding the necessary variables in builds.yml.

Manual testing steps

  1. Go to https://snaps.metamask.io/
  2. Connect a snap
  3. Go back to the extension an check that the snap has been loaded

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained:
    • What problem this PR is solving.
    • How this problem was solved.
    • How reviewers can test my changes.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@zone-live zone-live requested review from a team as code owners September 20, 2023 10:31
@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@zone-live zone-live added team-mmi PRs from the MMI team release-11.2.0 Issue or pull request that will be included in release 11.2.0 labels Sep 20, 2023
@zone-live
Copy link
Contributor Author

@metamaskbot update-policies

@metamaskbot
Copy link
Collaborator

Policies updated

@metamaskbot
Copy link
Collaborator

Builds ready [701688d]
Page Load Metrics (1466 ± 34 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint105157130157
domContentLoaded1344161414667134
load1344161414667134
domInteractive1344161414667134
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

hmalik88
hmalik88 approved these changes Sep 22, 2023
View reviewed changes
Copy link
Contributor

@hmalik88 hmalik88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💪

@zone-live zone-live merged commit 6bddeba into develop Sep 24, 2023
9 checks passed
@zone-live zone-live deleted the MMI-3851-add-snaps-to-mmi-build branch September 24, 2023 09:02
@github-actions github-actions bot locked and limited conversation to collaborators Sep 24, 2023
@metamaskbot metamaskbot added the release-11.3.0 Issue or pull request that will be included in release 11.3.0 label Sep 24, 2023
@danjm danjm added release-11.3.0 Issue or pull request that will be included in release 11.3.0 and removed release-11.3.0 Issue or pull request that will be included in release 11.3.0 release-11.2.0 Issue or pull request that will be included in release 11.2.0 labels Sep 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@hmalik88 hmalik88 hmalik88 approved these changes

@DDDDDanica DDDDDanica DDDDDanica approved these changes

@albertolive albertolive albertolive approved these changes

Assignees
No one assigned
Labels
release-11.3.0 Issue or pull request that will be included in release 11.3.0 team-mmi PRs from the MMI team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@zone-live @metamaskbot @albertolive @DDDDDanica @hmalik88 @danjm